Release February 2025 #1296
Open
Release February 2025 #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove comment that is not useful.
…vascript 1205 refactor formatting across javascript
Comment on lines
+1
to
+13
| #!/bin/bash | ||
| # Description | ||
| # | ||
| # This script sets up a collection directory for DataFed. | ||
| # It checks for necessary permissions and environment variables, | ||
| # creates the directory if it doesn't exist, and sets the correct ownership. | ||
| set -euf -o pipefail | ||
|
|
||
| readonly SCRIPT=$(realpath "${BASH_SOURCE}") | ||
| readonly SOURCE=$(dirname "$SCRIPT") | ||
| readonly PROJECT_ROOT=$(realpath "${SOURCE}"/../../) | ||
| readonly FILENAME=$(basename "${BASH_SOURCE}") | ||
|
|
There was a problem hiding this comment.
This is a nice script but I don't remember seeing any admin documentation for it's use.
| # implications on the CI pipelines as well as the ability to detect problems | ||
| # when standing up datafed. | ||
| # -e turns on failures if script hits a problem | ||
| set -euf -o pipefail | ||
|
|
||
| SCRIPT=$(realpath "$0") |
There was a problem hiding this comment.
This should have been BASH_SOURCE
Comment on lines
13
to
+15
| packages=("host" "libtool" "build-essential" "g++" "gcc" "autoconf" | ||
| "automake" "make" "git" "python3-pkg-resources" "python3-pip" "pkg-config" | ||
| "libglobus-common-dev" "wget" "jq" "sudo" "libboost-all-dev" "python3-venv") | ||
| "libglobus-common-dev" "wget" "jq" "sudo" "libboost-all-dev" "python3-venv" "libgssapi-krb5-2") |
There was a problem hiding this comment.
Documentation is missing for how and why each of these are needed.
Comment on lines
+5
to
+13
| # -e has been added back, password file deletion should be handled by another | ||
| # means such as the CI after script section. If the API fails to install, it | ||
| # could lead to improper testing the CI env. | ||
| # | ||
| # -e has been removed so that if an error occurs the PASSWORD File is deleted | ||
| # and not left lying around | ||
| # | ||
| # -u has been removed because we have no guarantees that the env variables are | ||
| # defined |
There was a problem hiding this comment.
These should have dates so it is clear which comment is the newest.
Comment on lines
+52
to
+64
| // { | ||
| // name: 'firefox', | ||
| // use: { | ||
| // ...devices['Desktop Firefox'], | ||
| // }, | ||
| // }, | ||
|
|
||
| // { | ||
| // name: 'webkit', | ||
| // use: { | ||
| // ...devices['Desktop Safari'], | ||
| // }, | ||
| // }, |
Fix bug in CI scripts associated with repo and gcs image build
| dbGetRaw(const char *a_url_path, | ||
| const std::vector<std::pair<std::string, std::string>> &a_params, | ||
| std::string &a_result); | ||
| bool dbGetRaw(const std::string url, std::string &a_result); |
There was a problem hiding this comment.
url should probably be a const reference.
Comment on lines
+56
to
62
| RUN curl -OL https://download.arangodb.com/arangodb312/DEBIAN/Release.key; apt-key add - < Release.key | ||
|
|
||
| # RUN echo 'deb https://download.arangodb.com/arangodb311/DEBIAN/ /' | tee /etc/apt/sources.list.d/arangodb.list | ||
| # If trust the site but the gpg key has expired can add [trusted=yes] | ||
| # i.e. | ||
| RUN echo 'deb [trusted=yes] https://download.arangodb.com/arangodb311/DEBIAN/ /' | tee /etc/apt/sources.list.d/arangodb.list | ||
| RUN echo 'deb [trusted=yes] https://download.arangodb.com/arangodb312/DEBIAN/ /' | tee /etc/apt/sources.list.d/arangodb.list | ||
| RUN apt update |
There was a problem hiding this comment.
ArangoDB version should be defined in one place and used consistently everywhere else.
Release february 2025
[DAPS-Deps] update Checker Ver
…epo service instead of hard coding
hotfix port mapping
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
…thread-counts 1321 feature config settings core thread counts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to track the progress of the deployment to production for February 12, 2025.