-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blake nedved rework docker building #916
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All files that need to be accessed by the user during docker run should be made accessible to the root group. This is a requirement of running with OpenShift.
Also, to encourage a decoupled design, let's split the single docker file into components that go in the respective web/ repo core etc... folders.
Something on the permissions of the web server are still off. Looks like the NVM posix permissions are not being handled correctly.
|
Description
This pull request includes changes that will simplify the docker build process and make it significantly faster and produce smaller images on average by better utilizing the docker cache, to do this the dockerfiles have be reorganized so that they all pull from one dependencies image and one runtime image so that way the dependencies only need to be built once.
Tasks
Work time
Expected time: 3 weeks