-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create tests for functions that will check ftp:// prefix #945
Closed
JoshuaSBrown
wants to merge
9
commits into
devel
from
JoshuaSBrown-limit-file-path-of-globus-colllections
Closed
Create tests for functions that will check ftp:// prefix #945
JoshuaSBrown
wants to merge
9
commits into
devel
from
JoshuaSBrown-limit-file-path-of-globus-colllections
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@par-hermes format |
…t-file-path-of-globus-colllections
@par-hermes format |
Base automatically changed from
JoshuaSBrown-automate-gcs-setup
to
JoshuaSBrown-upgrade-protobuf
April 10, 2024 03:44
JoshuaSBrown
changed the base branch from
JoshuaSBrown-upgrade-protobuf
to
JoshuaSBrown-libcurl-openssl
April 10, 2024 03:51
JoshuaSBrown
changed the base branch from
JoshuaSBrown-libcurl-openssl
to
JoshuaSBrown-upgrade-protobuf
April 10, 2024 03:51
@par-hermes format |
nedvedba
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, code is clean and well commented so it is very easy to follow.
JoshuaSBrown
deleted the
JoshuaSBrown-limit-file-path-of-globus-colllections
branch
August 29, 2024 14:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a feature to limit the viewable directory structure in Globus. Currently, when you are viewing the content of a Globus collection using the Globus web app, everything within the path is viewable. It remains to be seen if this function is still necessary. I believe that the request will still need to be processed by the core service and arango because what is viewable will be determined by what user is trying to access what on the machine.