Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tests for functions that will check ftp:// prefix #945

Closed

Conversation

JoshuaSBrown
Copy link
Collaborator

@JoshuaSBrown JoshuaSBrown commented Apr 4, 2024

Description

Adds a feature to limit the viewable directory structure in Globus. Currently, when you are viewing the content of a Globus collection using the Globus web app, everything within the path is viewable. It remains to be seen if this function is still necessary. I believe that the request will still need to be processed by the core service and arango because what is viewable will be determined by what user is trying to access what on the machine.

@JoshuaSBrown
Copy link
Collaborator Author

@par-hermes format

par-hermes and others added 2 commits April 6, 2024 04:44
@JoshuaSBrown
Copy link
Collaborator Author

@par-hermes format

Base automatically changed from JoshuaSBrown-automate-gcs-setup to JoshuaSBrown-upgrade-protobuf April 10, 2024 03:44
@JoshuaSBrown JoshuaSBrown changed the base branch from JoshuaSBrown-upgrade-protobuf to JoshuaSBrown-libcurl-openssl April 10, 2024 03:51
@JoshuaSBrown JoshuaSBrown changed the base branch from JoshuaSBrown-libcurl-openssl to JoshuaSBrown-upgrade-protobuf April 10, 2024 03:51
@JoshuaSBrown
Copy link
Collaborator Author

@par-hermes format

@JoshuaSBrown JoshuaSBrown requested a review from nedvedba April 10, 2024 03:52
Copy link
Collaborator

@nedvedba nedvedba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, code is clean and well commented so it is very easy to follow.

Base automatically changed from JoshuaSBrown-upgrade-protobuf to devel May 13, 2024 13:39
@JoshuaSBrown JoshuaSBrown deleted the JoshuaSBrown-limit-file-path-of-globus-colllections branch August 29, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants