Joshua s brown apache2 gcs data fed web compose fix #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-gcs-DataFed-web-compose-fix
…thub.com:ORNL/DataFed into JoshuaSBrown-apache2-gcs-DataFed-web-compose-fix
nedvedba
reviewed
May 16, 2024
repository/docker/Dockerfile.gcs
Outdated
| @@ -147,3 +152,4 @@ WORKDIR ${DATAFED_INSTALL_PATH}/authz | |||
| # NOTE If you do not overwrite the entrypoint file it will use the GCS instance | |||
| # provided one | |||
| ENTRYPOINT ["/datafed/source/repository/docker/entrypoint_authz.sh"] | |||
| #ENTRYPOINT ["sleep", "infinity"] | |||
There was a problem hiding this comment.
Looks to be a lot of debug information printing left in this file
|
@nedvedba I want you to get better about holding me accountable for PRs, I haven't provided a description about what problem it solves, updated the changelog or assigned labels to this PR. |
JoshuaSBrown
added
Component: Build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The docker compose build files were becoming cluttered, in this pr the build process is separated into three different folders.
Master scripts were created to assist with the build and run process they were prepended with compose_ and moved into /scripts this way each of the three compose options could use the same master scripts thus making the code DRY.