Add phasor dynamics bus and branch models #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add bus component model.
Corrected paths to figures in README files for phasor dynamics component models.
abirchfield
requested changes
Jan 10, 2025
|
|
||
| private: | ||
| // Default initial values for voltage and phase on PQ bus | ||
| ScalarT Va0_{0.0}; |
There was a problem hiding this comment.
This should be Vr0 and Vi0, along with the constructor.
| using BusData = GridKit::PowerSystemData::BusData<real_type, IdxT>; | ||
|
|
||
| Bus(); | ||
| Bus(ScalarT Va, ScalarT Vr); |
| */ | ||
| template <class ScalarT, typename IdxT> | ||
| Bus<ScalarT, IdxT>::Bus() | ||
| : Va0_(0.0), Vr0_(0.0) |
| */ | ||
| template <class ScalarT, typename IdxT> | ||
| Bus<ScalarT, IdxT>::Bus(ScalarT Va, ScalarT Vr) | ||
| : Va0_(Va), Vr0_(Vr) |
| */ | ||
| template <class ScalarT, typename IdxT> | ||
| Bus<ScalarT, IdxT>::Bus(BusData& data) | ||
| : Va0_(data.Vm * cos(data.Va)), Vr0_(data.Vm * sin(data.Va)) |
|
|
||
| A bus is a point of interconnection of electrical devices. Bus component model | ||
| also plays a key role in coupling system components. Each bus $`i`$ owns two | ||
| variables -- active and reactive voltage $`V_{ai}`$ and $`V_{ri}`$, |
There was a problem hiding this comment.
The terms "active and reactive voltage" have no physical meaning. We should say "real and imaginary components of the voltage phasor". Same thing with current. On the other hand, active and reactive power are OK to talk about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Models for a bus and a branch for phasor dynamics simulations are added. These models use current balance and Cartesian coordinates.