Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Aligning the code with contributing guidelines #42

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

shakedregev
Copy link
Collaborator

This is my first pass at the cleanup of the code. It's not ready yet.

  1. There's a stylistic choice of inline functions that does not really go with rest of the code. I want to understand the rationale or change it to regular functions.
  2. Most functions do not have explanations of their parameters (and are not marked in or out)

@shakedregev shakedregev requested a review from reid-g January 16, 2025 14:59
@shakedregev shakedregev self-assigned this Jan 16, 2025
@shakedregev shakedregev marked this pull request as draft January 16, 2025 14:59
@shakedregev shakedregev requested a review from pelesh January 16, 2025 15:25
@shakedregev
Copy link
Collaborator Author

I further noticed that COO_Matrix is incorrectly defined with an underscore. Is this on purpose?
I put comments in the code, you can search for "SR".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant