Preliminary command-line options parser

[pelesh]

Provides:

• Basic parser for command line options.
• Single test for iterative solvers through SystemSolver interface

[pelesh]

@kswirydo, after rebasing to the latest develop, unit tests for CGS1 pass, but functionality tests using CGS1 still fail, bot on CPU and GPU.

[cameronrutherford]

Largely nitpicks - this is in great shape

[kswirydo]

Looks good. Now I am running it to see how the CLO interface works in practice.

[kswirydo]

Okay, so I decided to try to break it:

./tests/functionality/sys_rand_gmres_test.exe -i randfgmres -s fwht -g cgs2
Segmentation fault (core dumped)

(should throw error if solver is wrong)
Also

./tests/functionality/sys_rand_gmres_test.exe -i fgmres -s fwht -g cgs2
Iterative solver results: 
	 Sketching method:                                    : fwht
	 Initial residual norm:          ||b-Ax_0||_2         : 7.8492037812761619e+03 
	 Initial relative residual norm: ||b-Ax_0||_2/||b||_2 : 1.0000000000000000e+00 
	 Final residual norm:            ||b-Ax||_2           : 7.2975483225447763e-09 
	 Final relative residual norm:   ||b-Ax||_2/||b||_2   : 9.2971829065677610e-13 
	 Number of iterations                                 : 19
Test PASSED

There should be NO sketching method is solver is FGMRES.

[kswirydo]

Also this (note there is no sketching method so it is set to default - but then the name is not displayed)

./tests/functionality/sys_rand_gmres_test.exe -i randgmres  -g cgs3
Sketching method  not recognized.
Setting sketching to the default (count).

[WARNING] Gram-Schmidt variant cgs2 not recognized.
[WARNING] Using default cgs2 Gram-Schmidt variant.
[WARNING] Sketching method  not recognized!
Using default.
Iterative solver results: 
	 Sketching method:                                    : 
	 Initial residual norm:          ||b-Ax_0||_2         : 7.8910952345032565e+03 
	 Initial relative residual norm: ||b-Ax_0||_2/||b||_2 : 1.0053370321875226e+00 
	 Final residual norm:            ||b-Ax||_2           : 1.1069282838889689e-08 
	 Final relative residual norm:   ||b-Ax||_2/||b||_2   : 1.4102427644055879e-12 
	 Number of iterations                                 : 19
Test PASSED

[pelesh]

If the option parameter is unrecognized, the test should fall back to the default. It should not segfault. I agree, sketching should not be printed, if randomized method is not used. This is easy to fix though.

[pelesh]

Also this (note there is no sketching method so it is set to default - but then the name is not displayed)

./tests/functionality/sys_rand_gmres_test.exe -i randgmres  -g cgs3
Sketching method  not recognized.
Setting sketching to the default (count).

[WARNING] Gram-Schmidt variant cgs2 not recognized.
[WARNING] Using default cgs2 Gram-Schmidt variant.
[WARNING] Sketching method  not recognized!
Using default.
Iterative solver results: 
	 Sketching method:                                    : 
	 Initial residual norm:          ||b-Ax_0||_2         : 7.8910952345032565e+03 
	 Initial relative residual norm: ||b-Ax_0||_2/||b||_2 : 1.0053370321875226e+00 
	 Final residual norm:            ||b-Ax||_2           : 1.1069282838889689e-08 
	 Final relative residual norm:   ||b-Ax||_2/||b||_2   : 1.4102427644055879e-12 
	 Number of iterations                                 : 19
Test PASSED

I cannot reproduce this. I get this when I make the same call:

$ ./tests/functionality/sys_rand_gmres_test.exe -i randgmres  -g cgs3
Unknown orthogonalization cgs3
Setting orthogonalization to the default (CGS2).

Results for randomized FGMRES solver
	 Sketching method:               count sketching
	 Orthogonalization method:       reorthogonalized classical Gram-Schmidt
	 Hardware backend:               HIP
	 Solver tolerance:               1e-12
	 Initial residual norm:          ||b-Ax_0||_2         : 7.9193852034106785e+03 
	 Initial relative residual norm: ||b-Ax_0||_2/||b||_2 : 1.0089412154519328e+00 
	 Final residual norm:            ||b-Ax||_2           : 5.0631784499176610e-09 
	 Final relative residual norm:   ||b-Ax||_2/||b||_2   : 6.4505631284482523e-13 
	 Number of iterations                                 : 19
Test PASSED

I pulled from the lates cli-params-dev.

[pelesh]

@kswirydo, I couldn't reproduce issues you reported. I will merge this but feel free to open an issue, if you still see these problems.