Delay log file creation #196
Conversation
|
This is ready for review. By the way, there is a ridiculous number of workflows and tests running in the GitHub Actions. It took a total of 239 minutes for the checks to run. That's almost 4 hours! |
wigging
force-pushed
the
empty-log-file
branch
from
b6438cc to
e0d365e
Compare
|
I rebased this with the dev branch to keep things in sync hence the force-pushed in the timeline. |
|
Ugh. I pulled in something from the dev branch that makes the formatter checks fail. |
wigging
force-pushed
the
empty-log-file
branch
from
6084313 to
c00a313
Compare
wigging
force-pushed
the
empty-log-file
branch
from
c00a313 to
478db55
Compare
|
What is the purpose of this in the - name: Clean up
run: |
make clean
find /home/runner/runners/ -type f -name "*.log" -exec sh -c 'echo {}; >"{}"' \; || true |
Plus: - Strenghtening identifier guarentee to group_ids in FlowceptLoops -- This was the cause of the recent GH workflows to fail - Removing loggers from client - Adding counts and deletes for objects and workflows in MongoDAO - Changing object inserts to objects insert_or_update - Fixes in torch capture, to support more configurations - Removing old main.py file
|
|
||
| checks: | ||
| runs-on: ubuntu-22.04 |
There was a problem hiding this comment.
Why did you specify an Ubuntu version?
There was a problem hiding this comment.
Because it makes it explicit on which version of Ubuntu is used in the workflow. Using ubuntu-latest does not make it clear on which version is considered "latest".
There was a problem hiding this comment.
I have fixed the code formats in the branch that I am working on.
To reduce conflicts, can you please rebase this branch with dev and apply your changes only to the file src/flowcept/commons/flowcept_logger.py?
Optionally, you can also apply your changes to the file .github/workflows/checks.yml
Nevermind. I will work on sync'ing the branches.
|
The changes in this PR have been synchronized with the PR #199. |
|
I was busy with a different project today and just now seeing all of this. Why did you have to merge this with another branch? |
Because I also created a branch from dev and I was working on it in parallel with your branch. I just synchronized both branches before merging into dev. |
The current version of flowcept creates an empty log file even when no log message is received. This pull request delays the creation of the log file until a log message is actually received. Resolves issue #172 .