fixing a select option should remove all the others.

[johrstrom]

When you fix a select option - it should highlight the fact that you've removed all the other options. Functionally I don't think it makes a difference if the exclude_options is populated because fixed is true - I just think it's an issue of uniformity in experience.

It should likely go the other way to. When you remove all but 1 select option, it should set it to fixed.

[abujeda]

I have been doing some analysis and prototyping on this.
I have implemented 2 approaches:

1 .- Disabling all options when fixed is selected:

2.- Emulating remove other options, but without updating the exclude list:

[abujeda]

As fixed and excluded attributes control different configuration settings, it feels that disabling all (option 1 above) is more consistent with the implementation.

[johrstrom]

2.- Emulating remove other options, but without updating the exclude list:

I like number 2 better - just from a visual/UX perspective. It makes me as the user really understand what's happening.

That said - it appears you do update the exclude list (even if we ignore it at later points). I get your concern around implementation, but I guess I'd have to give UX precedence here.

[abujeda]

OK - will continue with option 2

it appears you do update the exclude list....

In the current implementation, the exclude list is never updated when fixed is selected. I am just replicating the UI changes for the non selected items. But it will be easier to see once I submit the first draft PR.

[johrstrom]

In the current implementation, the exclude list is never updated when fixed is selected. I am just replicating the UI changes for the non selected items. But it will be easier to see once I submit the first draft PR.

OK - I guess I would question what happens when you fix, save, reload then unfix, then save again.

I guess I'm just looking for what you'd expect to happen to happen when you do that (fix, save and then un-fix).

[abujeda]

fix, save and then un-fix

At the moment, the exclude list will not be updated when using fix. So when you fix, save, and un-fix, It should render the UI using the last saved exclude list to disable those elements in the select dropdown.

Do you think that the exclude list should be "deleted" when fix is selected?
So that fix, save, and un-fix will simply start with an empty exclude list?

[johrstrom]

Do you think that the exclude list should be "deleted" when fix is selected?
So that fix, save, and un-fix will simply start with an empty exclude list?

I would guess the opposite. I mean my north star is what the user would expect to happen. As a user I'd expect when I un-fix the exclude list excludes everything besides the value I had just fixed to.

In any case - it seems like this is an edge case we can account for later. We can pick that up in another ticket if it gets too complicated in this one.

[abujeda]

created an initial PR: #3159