Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved form fixed field UI for new Job Composer scripts #3159

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

abujeda
Copy link
Contributor

@abujeda abujeda commented Nov 2, 2023

Fixes #3097

Improvements to the way select field options are managed when the fixed property is selected.

@abujeda
Copy link
Contributor Author

abujeda commented Nov 2, 2023

This is a demo of the behaviour:

fixed_fields

@johrstrom
Copy link
Contributor

I'll take a look at this shortly. Obviously tests are failing, possibly for good reason because of a behavior change. I'll have check that out to.

@johrstrom johrstrom self-requested a review November 2, 2023 18:41
@abujeda
Copy link
Contributor Author

abujeda commented Nov 2, 2023

Reviewing the tests....

@abujeda
Copy link
Contributor Author

abujeda commented Nov 3, 2023

Fixed tests

@johrstrom
Copy link
Contributor

Fixed tests

Thanks, I haven't gotten a chance to look this over yet because something came up with my house so I'm on vacation today. But I'll be sure to sort this out next week.

@johrstrom johrstrom self-assigned this Nov 6, 2023
@abujeda abujeda force-pushed the 3097_fixed_field_ui_updates branch from 8239365 to b5d504c Compare November 7, 2023 16:03
@johrstrom johrstrom self-requested a review November 7, 2023 16:58
Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@johrstrom johrstrom merged commit 36b2ea8 into OSC:master Nov 7, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fixing a select option should remove all the others.
3 participants