New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor and render status method #3171

Closed

akuppa9 wants to merge 1 commit into master from refactor-status-partials

Contributor

akuppa9 commented Nov 7, 2023

No description provided.


          refactor and render status method

ee98e3d

osc-bot added the component/dashboard label

Contributor

johrstrom commented Nov 7, 2023 •

edited

Loading

This does not and should not be refactored into a partial.

What does need to be refactored into a partial is anything that uses content_tag functions or generates HTML (i.e., returns long strings).

This is just a helper function and it can stay where/how it is.

johrstrom closed this

johrstrom deleted the refactor-status-partials branch

November 7, 2023 15:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/dashboard