adds error messages for syntax errors #3486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johrstrom
reviewed
Apr 2, 2024
johrstrom
reviewed
Apr 23, 2024
| announcements = Announcements.all(f.path) | ||
| announcement = announcements.first | ||
| assert_equal :warning, announcement.type | ||
| assert_send([announcement.instance_variable_get(:@error).to_str, :include?, "syntax error"]) |
There was a problem hiding this comment.
OK - I now see this is where you were using it!
If you're going to write a test for this, then maybe you should do something like this
Rails.logger.stubs(:warn).with("Syntax error in announcement ...").returns(0)that stubs the warning log line with the specific message and the test will fail if Rails.logger.warn is either called with different arguments (a different string) OR is never called at all.
johrstrom
previously approved these changes
Aug 22, 2024
johrstrom
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2700