Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

casts pinned app configuration into an array #3528

Closed
wants to merge 1 commit into from

Conversation

alarad27
Copy link
Contributor

Fixes #1810

@johrstrom
Copy link
Contributor

Given the tests, this appears to actually break functionality. Even so, I think the original ticket says you can maybe just to_a on the return value in the configuration_singleton.rb file to cast it.

@johrstrom
Copy link
Contributor

Sorry to have you do this only to find out that it's impossible. Apparently this changed from the time the ticket was opened to now. The configuration_singleton no longer handles this and thus can't cast to an array.

So there's nothing to be done because it's not clear how to cast in the ConfigurationProperty class.

Sorry! Hope everything's going well!

@johrstrom johrstrom closed this Aug 22, 2024
@johrstrom johrstrom deleted the 1810-pinned-apps-array branch August 22, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pinned apps not casting configuration to an array
3 participants