-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed ActiveJobsHelper dependency on ApplicationHelper #3892
Conversation
A sample error message from the logs
|
I can't replicate. What's more is, I think activejobs renders the label in javascript. ondemand/apps/dashboard/app/javascript/active_jobs.js Lines 133 to 144 in d8af2bf
Is the error stack coming from one of these rescue blocks? I'd have to look it over, but I don't think that should be a label string, it should be a symbol or string that's just
|
Are you testing with the latest from main? Not sure this change has made it to a release. For me the error happens in 2 places. On the call to
|
🤦♂️ it's when you expand one of the rows. I can take a look now. |
OK - I have 2 options for you. I can accept this, with another ticket to actually fix it, or we can actually fix it now. Seems like the issue originates here -
All helpers are available when rendering partials (just FYI, they're not namespaced, they're all available and can be overwritten/redefined as they're loaded). So what we should really do is refactor this so that the models just have a status string like |
OK - Will create the actual fix with this PR.
Looking into this |
fa7fc24
to
ac322be
Compare
I have completed the changes |
I found an issue with the |
6c21645
to
2485ad0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
After the refactoring completed in #3700, a dependency was added to the
ActiveJobsHelper
to render thestatus_label
method. The dependent method is inApplicationHelper
This is breaking the Active jobs > job details AJAX call.
This is a possible fix for the issue