Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint a random file #3946

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Lint a random file #3946

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions nginx_stage/lib/nginx_stage/socket_file.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'pathname'

module NginxStage
Expand Down Expand Up @@ -27,9 +29,8 @@ def socket
# Delete the socket from the file system
def delete
@socket.delete
rescue
$stderr.puts "Unable to delete socket file at #{socket}"
rescue StandardError
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think file Errors are StandardErrors so I can't pull this in as is. I.e., this wouldn't actually get rescued.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I'm wrong. This catches file errors.

warn "Unable to delete socket file at #{socket}"
end

end
end
Loading