Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes Handlebars from file action menu code #4070

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Removes Handlebars from file action menu code #4070

merged 1 commit into from
Jan 22, 2025

Conversation

HazelGrant
Copy link
Contributor

No description provided.

@HazelGrant HazelGrant marked this pull request as ready for review January 13, 2025 15:55
@HazelGrant HazelGrant requested a review from johrstrom January 13, 2025 15:56
johrstrom
johrstrom approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. I'd have the same comment I left about large functions in the other PR - this is OK for now, turbo may change all of this so it's fine to have huge functions.

@HazelGrant HazelGrant merged commit cbfd966 into master Jan 22, 2025
25 checks passed
@HazelGrant HazelGrant deleted the 4058-file_action_menu_handlebars_removal branch January 22, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johrstrom johrstrom johrstrom approved these changes

Assignees
No one assigned
Labels
component/dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HazelGrant @johrstrom @osc-bot