Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add returnFocus option to resolve focus issues in file_ops #4100

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add returnFocus option to resolve focus issues in file_ops #4100

wants to merge 3 commits into from

Conversation

ahmed-mgd
Copy link
Contributor

Fixes focus issues related to #4064
Follow-up to #4084

@ahmed-mgd ahmed-mgd changed the title Add returnFocus option to resolve focus conflicts after file operation errors Add returnFocus option to resolve focus issues in file_ops Jan 27, 2025
@johrstrom
Copy link
Contributor

I'm not 100% sure what this does. I don't see returnFocus being set anywhere. If it's always false, why pass it around here and there?

@johrstrom
Copy link
Contributor

Yea after looking at this for a second, I think I'm finding the default true is a better experience. So it's not clear to me if this fixes anything. For visual users, the default of true will correctly display the alert. For screen-readers, they do not get the alert regardless of returnFocus - they always seem to return to the very top of the page (the start of the navigation bar).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component/dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmed-mgd @johrstrom @osc-bot