Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add project manager to 4.0 release notes #1071

Merged
merged 2 commits into from
Jan 13, 2025
Merged

add project manager to 4.0 release notes #1071

merged 2 commits into from
Jan 13, 2025

Conversation

johrstrom
Copy link
Contributor

Modify this link to include the branch name, and possibly the page this PR modifies:

https://osc.github.io/ood-documentation-test/pm-rns

Add a note on the Project Manager in the 4.0 release notes.

@moffatsadeghi moffatsadeghi self-requested a review January 13, 2025 20:54
@johrstrom
Copy link
Contributor Author

Thanks, that misspelling CI cannot come soon enough.

Copy link
Contributor

@moffatsadeghi moffatsadeghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change "becuase" to "because"

@moffatsadeghi
Copy link
Contributor

moffatsadeghi commented Jan 13, 2025

Not sure if I messed anything up, but I tried to add myself as a reviewed and provide the feedback officially as a reviewer. Let me know if you don't want me to do it this way

@johrstrom
Copy link
Contributor Author

Not sure if I messed anything up, but I tried to add myself as a reviewed and provide the feedback officially as a reviewer. Let me know if you don't want me to do it this way

Nothing was messed up. Admittedly, I don't use that a lot or know a lot about it, but I think you left a review (which is 100% fine) then I pushed an update which got rid of your review.

Now, you've just approved, so I think that's exactly the workflow that should have happened.

@johrstrom johrstrom merged commit 7efaff6 into develop Jan 13, 2025
1 check passed
@johrstrom johrstrom deleted the pm-rns branch January 13, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants