-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSH Keyfile location support for systemd launcher/cluster #863
Conversation
We (OSC) use |
Hopefully make this "more ruby" like.
remove duplicate line.
removed duplicate end. My poor copy & paste skills...
Sorry for the delay - I'm still working through test cases that should have caught that issue (if there was one?) |
🤦♂️ I added a test for the linux_host adapter, not the systemd adapter. I'll get this merged shortly and add some tests for the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working through this with me!
No worries, I'm not well versed in git or ruby so I can only apologise for being slow and cumbersome. |
No issues at all. I'm happy to get a contribution in any form. Thanks again! |
This should give some (albeit poor quality) support for alternative ssh keyfile locations using the systemd launcher.
Our use case is so users don't have to think about ssh key generation etc to reduce a barrier of entry.
I don't write ruby so this is probably a mess.