Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPLGetPhysicalRAM(): cache result to avoid multiple file openings on repeated calls #11776

Merged
merged 1 commit into from
Jan 31, 2025
Merged

CPLGetPhysicalRAM(): cache result to avoid multiple file openings on repeated calls #11776

merged 1 commit into from
Jan 31, 2025
+129 −121

Conversation

rouault
Copy link
Member

@rouault rouault commented Jan 31, 2025

No description provided.

dbaston
dbaston approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@dbaston dbaston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplified diff: https://github.com/OSGeo/gdal/pull/11776/files?w=1

@pedros007
Copy link
Contributor

Simplified diff: https://github.com/OSGeo/gdal/pull/11776/files?w=1

Woah 🤯 I had no idea you could append ?w=1 to remove whitespace from a PR. Thanks for this tip!

@rouault rouault merged commit 64903e9 into OSGeo:master Jan 31, 2025
36 checks passed
@rouault rouault added this to the 3.11.0 milestone Jan 31, 2025
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 70.047% (-0.01%) from 70.058%
when pulling 6bc578b on rouault:CPLGetPhysicalRAM_cache
into 86193bf on OSGeo:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbaston dbaston dbaston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rouault @pedros007 @coveralls @dbaston