RFC107 candidate implementation #11813
Merged
+1,618
−2,569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
force-pushed
the
rfc107
branch
2 times, most recently
from
cf8969e to
5d5ce4e
Compare
rouault
added
the
funded through GSP
dbaston
approved these changes
Feb 10, 2025
rouault
force-pushed
the
rfc107
branch
2 times, most recently
from
7858fb3 to
0d2a882
Compare
…virtual ISetSpatialFilter()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(on top of PR #11794)
The OGRLayer::GetExtent(OGREnvelope*, int bForce) and
OGRLayer::GetExtent(int iGeomField, OGREnvelope*, int bForce) methods are
no longer virtual methods that are implemented by drivers. They are now
user facing methods (with the change that the
int bForceis now abool bForce). Drivers must implement IGetExtent(int iGeomField, OGREnvelope*,bool bForce). The user-facing method checks that the iGeomField value is in range.
Similarly for OGRLayer::GetExtent3D(int iGeomField, OGREnvelope3D*, int bForce)
which is now a user facing method (with the change that the
int bForceis now abool bForce). Drivers must implement IGetExtent3D(int iGeomField, OGREnvelope3D*,bool bForce). The user-facing method checks that the iGeomField value is in range.
The OGRLayer::SetSpatialFilter() and SetSpatialFilterRect() methods are
no longer virtual methods that are implemented by drivers. They are now
user facing methods (with the change that they return OGRErr instead of void,
and accept a
const OGRGeometry*). Drivers must implementISetSpatialFilter(int iGeomField, const OGRGeometry*). The user-facing methods
check that the iGeomField value is in range.