Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NGW: Fix unit tests and improvements #11835

Merged
merged 4 commits into from
Feb 12, 2025
Merged

NGW: Fix unit tests and improvements #11835

merged 4 commits into from
Feb 12, 2025

Conversation

BishopGIS
Copy link
Member

What does this PR do?

  1. Fix current unit tests.
  2. Add http request timeouts (connect timeout, timeout, retry count, retry timeout).
  3. Add where clause to SQL delete command and unit test.
  4. Add coded field domain support and unit test.
  5. Add COG support.
  6. Add web map and basemap layer support as TMS sources.
  7. Add alter field support (name, alternative name, domain, comment).
  8. Update documantation.

What are related issues/pull requests?

Tasklist

  • [-] AI (Copilot or something similar) supported my development of this PR
  • Make sure code is correctly formatted (cf pre-commit configuration)
  • Add test case(s)
  • Add documentation
  • Updated Python API documentation (swig/include/python/docs/)
  • Review
  • Adjust for comments
  • All CI builds and checks have passed

Dmitry Baryshnikov added 3 commits February 10, 2025 11:16
NGW: Fix unittests. Add http request timeouts. Add where clause suppo…
b88924e 
…rt for SQL delete command. Add coded field domain support. Add COG support. Add alter field support.
Merge branch 'master' of github.com:BishopGIS/gdal
6150fb1
NGW: Format code
9bd5af5
@BishopGIS BishopGIS requested a review from rouault February 10, 2025 22:05
rouault
rouault reviewed Feb 11, 2025
View reviewed changes
Copy link
Member

@rouault rouault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extremely superficial review done. I let you address CI issues

autotest/gdrivers/ngw.py Outdated

gt = ds.GetGeoTransform()
# -20037508.34, 0.037322767712175846, 0.0, 20037508.34, 0.0, -0.037322767712175846
assert (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use assert gt == pytest.approx(expected_gt, abs=0.00001) to test the whole gt at once

@rouault rouault merged commit ca71560 into OSGeo:master Feb 12, 2025
37 checks passed
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 70.029%. first build
when pulling 9bd5af5 on BishopGIS:master
into ebf0679 on OSGeo:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rouault rouault rouault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BishopGIS @coveralls @rouault