Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: no longer use Ubuntu 20.04 github images that will be sunsetted April 1st #11840

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

rouault
Copy link
Member

@rouault rouault commented Feb 11, 2025

No description provided.

@rouault rouault added the funded through GSP Work funded through the GDAL Sponsorship Program label Feb 11, 2025
@rouault rouault force-pushed the ci_no_longer_use_20.04 branch 7 times, most recently from 00cbdc7 to bed7cbf Compare February 12, 2025 14:58
@rouault rouault force-pushed the ci_no_longer_use_20.04 branch from bed7cbf to 72ec8b8 Compare February 12, 2025 19:17
@rouault
Copy link
Member Author

rouault commented Feb 12, 2025

@dbaston @elpaso I'm at loss why the update fail / don't have the energy to dig. Can we share the shitty job of maintaining CI ?

@coveralls
Copy link
Collaborator

coveralls commented Feb 13, 2025

Coverage Status

coverage: 70.038% (-0.002%) from 70.04%
when pulling 28c2ecb on rouault:ci_no_longer_use_20.04
into ca71560 on OSGeo:master.

@elpaso
Copy link
Collaborator

elpaso commented Feb 13, 2025

@dbaston @elpaso I'm at loss why the update fail / don't have the energy to dig. Can we share the shitty job of maintaining CI ?

I can try.

@elpaso elpaso self-assigned this Feb 13, 2025
@elpaso
Copy link
Collaborator

elpaso commented Feb 13, 2025

I am trying to replicate the issue locally with vscode gh local action but I'm stuck at

[Build and test with CMake/build-linux-ubuntu-jammy] gpg: keybox '/tmp/tmp3eik162y/pubring.gpg' created
[Build and test with CMake/build-linux-ubuntu-jammy] gpg: /tmp/tmp3eik162y/trustdb.gpg: trustdb created
[Build and test with CMake/build-linux-ubuntu-jammy] gpg: key FF0E7BBEC491C6A1: public key "Launchpad PPA for UbuntuGIS" imported
[Build and test with CMake/build-linux-ubuntu-jammy] gpg: Total number processed: 1
[Build and test with CMake/build-linux-ubuntu-jammy] gpg:               imported: 1
[Build and test with CMake/build-linux-ubuntu-jammy] Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).
[Build and test with CMake/build-linux-ubuntu-jammy] gpg: no valid OpenPGP data found.
[Build and test with CMake/build-linux-ubuntu-jammy] Exception in thread Thread-1:
[Build and test with CMake/build-linux-ubuntu-jammy] Traceback (most recent call last):
[Build and test with CMake/build-linux-ubuntu-jammy]   File "/usr/lib/python3.9/threading.py", line 954, in _bootstrap_inner
[Build and test with CMake/build-linux-ubuntu-jammy]     self.run()
[Build and test with CMake/build-linux-ubuntu-jammy]   File "/usr/lib/python3.9/threading.py", line 892, in run
[Build and test with CMake/build-linux-ubuntu-jammy]     self._target(*self._args, **self._kwargs)
[Build and test with CMake/build-linux-ubuntu-jammy]   File "/usr/lib/python3/dist-packages/softwareproperties/SoftwareProperties.py", line 688, in addkey_func
[Build and test with CMake/build-linux-ubuntu-jammy]     func(**kwargs)
[Build and test with CMake/build-linux-ubuntu-jammy]   File "/usr/lib/python3/dist-packages/softwareproperties/ppa.py", line 386, in add_key
[Build and test with CMake/build-linux-ubuntu-jammy]     return apsk.add_ppa_signing_key()
[Build and test with CMake/build-linux-ubuntu-jammy]   File "/usr/lib/python3/dist-packages/softwareproperties/ppa.py", line 273, in add_ppa_signing_key
[Build and test with CMake/build-linux-ubuntu-jammy]     cleanup(tmp_keyring_dir)
[Build and test with CMake/build-linux-ubuntu-jammy]   File "/usr/lib/python3/dist-packages/softwareproperties/ppa.py", line 234, in cleanup
[Build and test with CMake/build-linux-ubuntu-jammy]     shutil.rmtree(tmp_keyring_dir)
[Build and test with CMake/build-linux-ubuntu-jammy]   File "/usr/lib/python3.9/shutil.py", line 718, in rmtree
[Build and test with CMake/build-linux-ubuntu-jammy]     _rmtree_safe_fd(fd, path, onerror)
[Build and test with CMake/build-linux-ubuntu-jammy]   File "/usr/lib/python3.9/shutil.py", line 675, in _rmtree_safe_fd
[Build and test with CMake/build-linux-ubuntu-jammy]     onerror(os.unlink, fullname, sys.exc_info())
[Build and test with CMake/build-linux-ubuntu-jammy]   File "/usr/lib/python3.9/shutil.py", line 673, in _rmtree_safe_fd
[Build and test with CMake/build-linux-ubuntu-jammy]     os.unlink(entry.name, dir_fd=topfd)
[Build and test with CMake/build-linux-ubuntu-jammy] FileNotFoundError: [Errno 2] No such file or directory: 'S.gpg-agent.ssh'

I tried

diff --git a/.github/workflows/cmake_builds.yml b/.github/workflows/cmake_builds.yml
index a06b7788cc..8db4080a3e 100644
--- a/.github/workflows/cmake_builds.yml
+++ b/.github/workflows/cmake_builds.yml
@@ -37,6 +37,10 @@ jobs:
     steps:
     - name: Checkout GDAL
       uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
+    - name: Install Act dependencies
+      if: ${{ env.ACT }}
+      run: |
+        apt-get update && apt-get install software-properties-common gnupg gnupg-agent ssh sudo -y && gpg-agent --daemon
     - name: Setup cache
       uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2.0
       id: cache

Any idea?

@elpaso
Copy link
Collaborator

elpaso commented Feb 13, 2025

I am now trying the old hard way with a manually build dockerfile.

@elpaso
Copy link
Collaborator

elpaso commented Feb 13, 2025

@rouault apparently you now need local/lib instead of lib

diff --git a/.github/workflows/cmake_builds.yml b/.github/workflows/cmake_builds.yml
index a06b7788cc..564e210717 100644
--- a/.github/workflows/cmake_builds.yml
+++ b/.github/workflows/cmake_builds.yml
@@ -217,17 +217,17 @@ jobs:
         test -f $GITHUB_WORKSPACE/install-gdal/share/man/man1/gdaladdo.1
         export LD_LIBRARY_PATH=$GITHUB_WORKSPACE/install-gdal/lib
         $GITHUB_WORKSPACE/install-gdal/bin/gdalinfo --version
-        PYTHONPATH=$GITHUB_WORKSPACE/install-gdal/lib/python3.10/dist-packages python3 -c "from osgeo import gdal;print(gdal.VersionInfo(None))"
+        PYTHONPATH=$GITHUB_WORKSPACE/install-gdal/local/lib/python3.10/dist-packages python3 -c "from osgeo import gdal;print(gdal.VersionInfo(None))"
         # Test fix for https://github.com/conda-forge/gdal-feedstock/issues/995
         PYTHONWARNINGS="error" PYTHONPATH=$GITHUB_WORKSPACE/install-gdal/lib/python3.10/dist-packages python3 -c "from osgeo import gdal"
-        PYTHONPATH=$GITHUB_WORKSPACE/install-gdal/lib/python3.10/dist-packages python3 $GITHUB_WORKSPACE/scripts/check_doc.py
+        PYTHONPATH=$GITHUB_WORKSPACE/install-gdal/local/lib/python3.10/dist-packages python3 $GITHUB_WORKSPACE/scripts/check_doc.py
     - name: CMake with rpath
       run: |
         export PATH=$CMAKE_DIR:/usr/local/bin:/usr/bin:/bin # Avoid CMake config from brew etc.
         (cd $GITHUB_WORKSPACE/superbuild/build; cmake .. "-DCMAKE_INSTALL_PREFIX=$GITHUB_WORKSPACE/install-gdal-with-rpath" "-DCMAKE_INSTALL_RPATH=$GITHUB_WORKSPACE/install-gdal-with-rpath/lib")
         cmake --build $GITHUB_WORKSPACE/superbuild/build --target install -- -j$(nproc)
         # For some reason, during the install phase of above invocation, the Python bindings are rebuilt after the build phase, and without the rpath... Can't reproduce that locally
-        # PYTHONPATH=$GITHUB_WORKSPACE/install-gdal-with-rpath/lib/python3.10/site-packages python -c "from osgeo import gdal;print(gdal.VersionInfo(None))"
+        # PYTHONPATH=$GITHUB_WORKSPACE/install-gdal-with-rpath/local/lib/python3.10/site-packages python -c "from osgeo import gdal;print(gdal.VersionInfo(None))"
     - name: Rerun using Mono
       run: |
         export PATH=$CMAKE_DIR:/usr/local/bin:/usr/bin:/bin # Avoid CMake config from brew etc.

@elpaso
Copy link
Collaborator

elpaso commented Feb 13, 2025

scripts/check_doc.py Outdated Show resolved Hide resolved
@dbaston
Copy link
Member

dbaston commented Feb 13, 2025

Can we share the shitty job of maintaining CI ?

Yes of course, please feel free to assign the next one to me.

These is an inconsistency in 'bin' paths with/without 'local' for gdalinfo and probably other utilities... I cannot understan why.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
funded through GSP Work funded through the GDAL Sponsorship Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants