Added Refactoring changes #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harismuneer
requested changes
Mar 24, 2022
| @@ -15,6 +15,9 @@ The **Class Diagram** of the project is also provided along with the **Database | |||
| ## Class Diagram | |||
|  | |||
|
|
|||
| **Note**: After Refactoring, new Class "HoldRequestOperations" is added to the above structure which lies in between the HoldRequest class and Book class. | |||
| This class removes the bidirectional dependency between HoldRequest and Book. | |||
|
|
|||
There was a problem hiding this comment.
@guryashdhall can we add why we made this new class and the context for this decision. Will be helpful for the readers.
There was a problem hiding this comment.
@harismuneer sure i will update the same
There was a problem hiding this comment.
@harismuneer I have updated the reasoning behind the introduction of new class in the README
|
@guryashdhall I am merging the PR with the note that a subsequent code review from your peers would be required to ensure integrity. |
|
@harismuneer I have reviewed the changes and tested the functionality , the changes made by @guryashdhall are just refactoring changes and has no effect on the working of the Library Management System |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details of the Refactoring are present in the issue:- #9