Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting of Operation Life #37

Merged
merged 7 commits into from
Dec 5, 2023
Merged

Conversation

HauHe
Copy link
Contributor

@HauHe HauHe commented Nov 21, 2023

This PR allows to report the IAMC variable Lifetime using the OSeMOSYS parameter OperationalLife. The Operational Life is reported for each year in the Modelling period.

The PR addresses #36

…t the Life Time of technologies using the OSeMOSYS parameter OperationalLife. In the current implementation it is important to provide regex in the config file that will filter to only one technology per country.
@HauHe HauHe added the enhancement New feature or request label Nov 21, 2023
@HauHe HauHe requested a review from willu47 November 21, 2023 16:48
@HauHe
Copy link
Contributor Author

HauHe commented Nov 22, 2023

@willu47 could you have a look at the checks below that are failing? The error messages are somewhat cryptic to me.
Should I fix something before merging?

@willu47
Copy link
Member

willu47 commented Nov 24, 2023

Hi @HauHe - the checks are failing due to the "linting". Linting checks the formatting of the code is correct. You need to install the pre-commit checks to pass these checks. The easy way to do this is to use tox:

pip install tox
tox -e lint

@HauHe
Copy link
Contributor Author

HauHe commented Nov 29, 2023

Hm, used lint and it changed some dashes from single to double. But there seems to be still some issue.

@willu47
Copy link
Member

willu47 commented Nov 29, 2023

The tests are failing because no YEAR.csv file is provided in the tests/fixtures/YEAR.csv path.

@HauHe
Copy link
Contributor Author

HauHe commented Nov 30, 2023

Ok, interesting, so the check sees that I read in YEAR.csv and therefore expects that I have a test including YEAR.csv?
Because I didn't write a test including YEAR.csv. Do I need to write a corresponding test?

@HauHe
Copy link
Contributor Author

HauHe commented Nov 30, 2023

Seems I managed to fix it by adding a YEAR.csv file to tests/fixtures and tests/fixtures/trade

@HauHe
Copy link
Contributor Author

HauHe commented Dec 1, 2023

Hi @willu47 , not sure if necessary, but would you like to have a look before merging?

Copy link
Member

@willu47 willu47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @HauHe

@HauHe HauHe merged commit 46ef6a1 into OSeMOSYS:main Dec 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants