Added name overwrite function to redis charts #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix redis-sentinel selector role value Signed-off-by: whzghb <[email protected]> * fix lints Signed-off-by: Shubham Gupta <[email protected]> * fix linl-2 Signed-off-by: Shubham Gupta <[email protected]> --------- Signed-off-by: whzghb <[email protected]> Signed-off-by: Shubham Gupta <[email protected]> Co-authored-by: Shubham Gupta <[email protected]> Signed-off-by: EStork09 <[email protected]>
Signed-off-by: EStork09 <[email protected]>
Signed-off-by: EStork09 <[email protected]>
charts/redis-cluster/values.yaml
Outdated
| @@ -68,6 +68,9 @@ redisCluster: | |||
| maxUnavailable: 1 | |||
| minAvailable: 1 | |||
|
|
|||
| # Overwite name for resources | |||
| # name: "" | |||
There was a problem hiding this comment.
Uncomment this field and move that to redisCluster:
empty string don't have any effect it would fall back to default anyways
There was a problem hiding this comment.
Do same with other charts.
Signed-off-by: EStork09 <[email protected]>
Signed-off-by: EStork09 <[email protected]>
Signed-off-by: EStork09 <[email protected]>
mrhovunping
pushed a commit
to mrhovunping/bug-165
that referenced
this pull request
Nov 28, 2023
* fix redis-sentinel selector role value (OT-CONTAINER-KIT#164) * fix redis-sentinel selector role value Signed-off-by: whzghb <[email protected]> * fix lints Signed-off-by: Shubham Gupta <[email protected]> * fix linl-2 Signed-off-by: Shubham Gupta <[email protected]> --------- Signed-off-by: whzghb <[email protected]> Signed-off-by: Shubham Gupta <[email protected]> Co-authored-by: Shubham Gupta <[email protected]> Signed-off-by: EStork09 <[email protected]> * Added name overwrite function to redis charts Signed-off-by: EStork09 <[email protected]> * Bumpped versions Signed-off-by: EStork09 <[email protected]> * Moved fields for name under specific configuration Signed-off-by: EStork09 <[email protected]> * Adjusted values.yaml to address linting report Signed-off-by: EStork09 <[email protected]> * Addressed linting errors Signed-off-by: EStork09 <[email protected]> --------- Signed-off-by: whzghb <[email protected]> Signed-off-by: Shubham Gupta <[email protected]> Signed-off-by: EStork09 <[email protected]> Co-authored-by: whzghb <[email protected]> Co-authored-by: Shubham Gupta <[email protected]> Signed-off-by: Sébastien HO <[email protected]>
mrhovunping
pushed a commit
to mrhovunping/bug-165
that referenced
this pull request
Nov 28, 2023
* fix redis-sentinel selector role value (OT-CONTAINER-KIT#164) * fix redis-sentinel selector role value Signed-off-by: whzghb <[email protected]> * fix lints Signed-off-by: Shubham Gupta <[email protected]> * fix linl-2 Signed-off-by: Shubham Gupta <[email protected]> --------- Signed-off-by: whzghb <[email protected]> Signed-off-by: Shubham Gupta <[email protected]> Co-authored-by: Shubham Gupta <[email protected]> Signed-off-by: EStork09 <[email protected]> * Added name overwrite function to redis charts Signed-off-by: EStork09 <[email protected]> * Bumpped versions Signed-off-by: EStork09 <[email protected]> * Moved fields for name under specific configuration Signed-off-by: EStork09 <[email protected]> * Adjusted values.yaml to address linting report Signed-off-by: EStork09 <[email protected]> * Addressed linting errors Signed-off-by: EStork09 <[email protected]> --------- Signed-off-by: whzghb <[email protected]> Signed-off-by: Shubham Gupta <[email protected]> Signed-off-by: EStork09 <[email protected]> Co-authored-by: whzghb <[email protected]> Co-authored-by: Shubham Gupta <[email protected]> Signed-off-by: Sébastien HO <[email protected]>
mrhovunping
pushed a commit
to mrhovunping/bug-165
that referenced
this pull request
Nov 28, 2023
* fix redis-sentinel selector role value (OT-CONTAINER-KIT#164) * fix redis-sentinel selector role value Signed-off-by: whzghb <[email protected]> * fix lints Signed-off-by: Shubham Gupta <[email protected]> * fix linl-2 Signed-off-by: Shubham Gupta <[email protected]> --------- Signed-off-by: whzghb <[email protected]> Signed-off-by: Shubham Gupta <[email protected]> Co-authored-by: Shubham Gupta <[email protected]> Signed-off-by: EStork09 <[email protected]> * Added name overwrite function to redis charts Signed-off-by: EStork09 <[email protected]> * Bumpped versions Signed-off-by: EStork09 <[email protected]> * Moved fields for name under specific configuration Signed-off-by: EStork09 <[email protected]> * Adjusted values.yaml to address linting report Signed-off-by: EStork09 <[email protected]> * Addressed linting errors Signed-off-by: EStork09 <[email protected]> --------- Signed-off-by: whzghb <[email protected]> Signed-off-by: Shubham Gupta <[email protected]> Signed-off-by: EStork09 <[email protected]> Co-authored-by: whzghb <[email protected]> Co-authored-by: Shubham Gupta <[email protected]> Signed-off-by: Sébastien HO <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #116
I don't think this is exactly the end solution. Many other charts will use a helper function to handle the naming, but this will address the request for right now.
I also assume the chart version needs to be bumped