Merge pull request #345 from iamabhishek-dubey/persistence-fix

[BugFix]Fixed issue for redis persistence
OT-CONTAINER-KIT · Oct 7, 2022 · 415af77 · 415af77
2 parents dcc4c8f + 3c91672
commit 415af77
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 1 deletion.
diff --git a/api/v1beta1/rediscluster_types.go b/api/v1beta1/rediscluster_types.go
@@ -39,6 +39,7 @@ type RedisClusterSpec struct {
 	TLS                *TLSConfig                   `json:"TLS,omitempty"`
 	Sidecars           *[]Sidecar                   `json:"sidecars,omitempty"`
 	ServiceAccountName *string                      `json:"serviceAccountName,omitempty"`
+	PersistenceEnabled *bool                        `json:"persistenceEnabled,omitempty"`
 }
 
 func (cr *RedisClusterSpec) GetReplicaCounts(t string) int32 {

diff --git a/api/v1beta1/zz_generated.deepcopy.go b/api/v1beta1/zz_generated.deepcopy.go
diff --git a/config/crd/bases/redis.redis.opstreelabs.in_redisclusters.yaml b/config/crd/bases/redis.redis.opstreelabs.in_redisclusters.yaml
@@ -194,6 +194,8 @@ spec:
                 additionalProperties:
                   type: string
                 type: object
+              persistenceEnabled:
+                type: boolean
               priorityClassName:
                 type: string
               redisExporter:

diff --git a/k8sutils/redis-cluster.go b/k8sutils/redis-cluster.go
@@ -83,8 +83,10 @@ func generateRedisClusterContainerParams(cr *redisv1beta1.RedisCluster, readines
 	if livenessProbeDef != nil {
 		containerProp.LivenessProbe = livenessProbeDef
 	}
-	if cr.Spec.Storage != nil {
+	if cr.Spec.Storage != nil && *cr.Spec.PersistenceEnabled {
 		containerProp.PersistenceEnabled = &trueProperty
+	} else {
+		containerProp.PersistenceEnabled = &falseProperty
 	}
 	if cr.Spec.TLS != nil {
 		containerProp.TLSConfig = cr.Spec.TLS