headless PublishNotReadyAddresses

Signed-off-by: Jordan Rodgers <[email protected]>
OT-CONTAINER-KIT · Aug 2, 2024 · ae15bc7 · ae15bc7
1 parent e5425a5
commit ae15bc7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/k8sutils/services.go b/k8sutils/services.go
@@ -55,6 +55,7 @@ func generateServiceDef(serviceMeta metav1.ObjectMeta, epp exporterPortProvider,
 	}
 	if headless {
 		service.Spec.ClusterIP = "None"
+		service.Spec.PublishNotReadyAddresses = true
 	}
 	if exporterPort, ok := epp(); ok {
 		redisExporterService := enableMetricsPort(exporterPort)

diff --git a/k8sutils/services_test.go b/k8sutils/services_test.go
@@ -102,9 +102,10 @@ func TestGenerateServiceDef(t *testing.T) {
 							Protocol:   corev1.ProtocolTCP,
 						},
 					},
-					Selector:  map[string]string{"role": "sentinel"},
-					ClusterIP: "None",
-					Type:      corev1.ServiceTypeClusterIP,
+					Selector:                 map[string]string{"role": "sentinel"},
+					ClusterIP:                "None",
+					Type:                     corev1.ServiceTypeClusterIP,
+					PublishNotReadyAddresses: true,
 				},
 			},
 		},
@@ -184,9 +185,10 @@ func TestGenerateServiceDef(t *testing.T) {
 							Protocol:   corev1.ProtocolTCP,
 						},
 					},
-					Selector:  map[string]string{"role": "redis"},
-					ClusterIP: "None",
-					Type:      corev1.ServiceTypeClusterIP,
+					Selector:                 map[string]string{"role": "redis"},
+					ClusterIP:                "None",
+					Type:                     corev1.ServiceTypeClusterIP,
+					PublishNotReadyAddresses: true,
 				},
 			},
 		},