Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add image pull secret for redis operator #1053

Conversation

civkule
Copy link
Contributor

@civkule civkule commented Aug 27, 2024

This PR introduces the addition of imagePullSecrets support in the redis-operator Helm chart. This allows users to specify image pull secrets, which is essential for pulling images from private Docker registries.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

civkule and others added 2 commits August 27, 2024 16:21
Added imagePullSecret for redis-operator in operator-deployment.yaml file

Signed-off-by: civkule <[email protected]>
@civkule civkule force-pushed the feat/imagePullSecret-for-redis-operator branch from 4e24c5e to 4aee889 Compare August 27, 2024 13:22
@drivebyer drivebyer changed the title Feat/image pull secret for redis operator feat: add image pull secret for redis operator Aug 30, 2024
@drivebyer drivebyer enabled auto-merge (squash) August 30, 2024 09:16
Copy link
Collaborator

@drivebyer drivebyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drivebyer drivebyer merged commit 1091124 into OT-CONTAINER-KIT:master Aug 30, 2024
9 of 10 checks passed
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.19%. Comparing base (d121d86) to head (4aee889).
Report is 95 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1053       +/-   ##
===========================================
+ Coverage   35.20%   46.19%   +10.99%     
===========================================
  Files          19       20        +1     
  Lines        3213     2704      -509     
===========================================
+ Hits         1131     1249      +118     
+ Misses       2015     1380      -635     
- Partials       67       75        +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants