Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Probe use built-in, discarded healthcheck.sh #444

Closed
wants to merge 1 commit into from
Closed

feat: Probe use built-in, discarded healthcheck.sh #444

wants to merge 1 commit into from

Conversation

muicoder
Copy link
Contributor

Description

Feature: #443

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Testing has been performed
  • No functionality is broken
  • Documentation updated

@muicoder muicoder changed the title Probe use built-in, discarded healthcheck.sh [Feature]: Probe use built-in, discarded healthcheck.sh Feb 21, 2023
@muicoder muicoder force-pushed the healthcheck branch 20 times, most recently from 8a8c8a2 to 22851ea Compare February 22, 2023 06:16
@muicoder muicoder changed the title [Feature]: Probe use built-in, discarded healthcheck.sh [Feature]: Probe use built-in(unixsock), discarded healthcheck.sh Feb 22, 2023
@muicoder muicoder changed the title [Feature]: Probe use built-in(unixsock), discarded healthcheck.sh [Feature]: Probe use built-in, discarded healthcheck.sh Feb 22, 2023
@muicoder muicoder force-pushed the healthcheck branch 2 times, most recently from 28e865f to f80c8a0 Compare February 22, 2023 08:32
@muicoder muicoder changed the title [Feature]: Probe use built-in, discarded healthcheck.sh [Feature] Probe use built-in, discarded healthcheck.sh Feb 22, 2023
@muicoder muicoder force-pushed the healthcheck branch 2 times, most recently from afe4b60 to 35b37d4 Compare February 22, 2023 09:19
@muicoder
Copy link
Contributor Author

@shubham-cmyk Tested as expected, please check.

@genofire
Copy link

any update?

@muicoder muicoder closed this Dec 14, 2023
@genofire
Copy link

is there a reason, why this was closed?

does any other patch get the exporter in combination with sentinal working?

@muicoder
Copy link
Contributor Author

muicoder commented Dec 25, 2023 •
edited
Loading

is there a reason, why this was closed?

does any other patch get the exporter in combination with sentinal working?

Change probeCommand to append mode
Repush later based on master branch (conflicting)

@muicoder muicoder reopened this Dec 25, 2023
@muicoder muicoder force-pushed the healthcheck branch 3 times, most recently from 1545107 to 7438363 Compare December 26, 2023 02:14
@codecov Codecov
Copy link

codecov bot commented Dec 26, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 36.10%. Comparing base (d121d86) to head (5204908).
Report is 14 commits behind head on master.

Files Patch % Lines
k8sutils/statefulset.go 0.00% 24 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #444      +/-   ##
==========================================
+ Coverage   35.20%   36.10%   +0.90%     
==========================================
  Files          19       19              
  Lines        3213     2631     -582     
==========================================
- Hits         1131      950     -181     
+ Misses       2015     1613     -402     
- Partials       67       68       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muicoder muicoder force-pushed the healthcheck branch 2 times, most recently from 9697233 to 9387285 Compare January 10, 2024 10:38
@wkd-woo
Copy link
Contributor

wkd-woo commented Feb 29, 2024

any update?

@muicoder
Copy link
Contributor Author

muicoder commented Feb 29, 2024 •
edited
Loading

any update?

updated

@muicoder muicoder force-pushed the healthcheck branch 2 times, most recently from 6734115 to 9190770 Compare March 4, 2024 02:51
@shubham-cmyk
Copy link
Member

I would get this merged in this release

@muicoder muicoder force-pushed the healthcheck branch 2 times, most recently from 8001004 to 9781820 Compare March 25, 2024 03:05
@drivebyer drivebyer changed the title [Feature] Probe use built-in, discarded healthcheck.sh feat: Probe use built-in, discarded healthcheck.sh Mar 26, 2024
@drivebyer drivebyer enabled auto-merge (squash) March 26, 2024 05:42
@muicoder
Probe use built-in, discarded healthcheck.sh
5204908 
Signed-off-by: muicoder <[email protected]>
https://github.com/redis/redis/blob/unstable/TLS.md
The probe uses env mode to load the TLS certificate.
auto-merge was automatically disabled March 28, 2024 02:29

Head branch was pushed to by a user without write access

@shubham-cmyk shubham-cmyk mentioned this pull request Apr 1, 2024
Closed
4 tasks
@drivebyer
Copy link
Collaborator

I noticed that it has been a long time since it was last updated, but I think this change is very important. I would like to raise another PR to implement it.

@muicoder
Copy link
Contributor Author

I noticed that it has been a long time since it was last updated, but I think this change is very important. I would like to raise another PR to implement it.

Welcome 👍🏻 😀 👍🏼 👍🏽

@drivebyer
Copy link
Collaborator

It's been done by #907, thanks @muicoder

@drivebyer drivebyer closed this May 6, 2024
@muicoder muicoder deleted the healthcheck branch May 6, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genofire genofire genofire approved these changes

@iamabhishek-dubey iamabhishek-dubey Awaiting requested review from iamabhishek-dubey iamabhishek-dubey is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@muicoder @shubham-cmyk @genofire @wkd-woo @drivebyer @iamabhishek-dubey