Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:resize cluster's pvc with wrong label #562

Merged
merged 1 commit into from
Sep 16, 2023
Merged

fix:resize cluster's pvc with wrong label #562

merged 1 commit into from
Sep 16, 2023

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Jul 20, 2023 •
edited
Loading

Resize pvc for RedisCluster

Description

  1. pvc for RedisCluster have labels：
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: xxxx
  labels:
    app: test-redis-c-leader
    app.kubernetes.io/component: redis
    app.kubernetes.io/name: test-redis-c
    redis_setup_type: cluster
    role: leader

Here app is sts's Name,app. kubernetes.io/name is CR's name,so we match label just app and redis

Fixes #ISSUE

Type of change

Bug fix

  • Bug fix

Checklist

  • Testing has been performed
  • No functionality is broken
  • Documentation updated

@jiuker
Copy link
Contributor Author

jiuker commented Jul 20, 2023

@shubham-cmyk

@jiuker
Copy link
Contributor Author

jiuker commented Aug 9, 2023

@shubham-cmyk cc

@shubham-cmyk shubham-cmyk merged commit 4395ff6 into OT-CONTAINER-KIT:master Sep 16, 2023
drivebyer pushed a commit to ksmartdata/redis-operator that referenced this pull request Dec 4, 2023
@jiuker @drivebyer
fix:resize cluster's pvc with wrong label (OT-CONTAINER-KIT#562)
f79a0e4 
Signed-off-by: guozhi.li <[email protected]>
Co-authored-by: guozhi.li <[email protected]>
(cherry picked from commit 4395ff6)
drivebyer pushed a commit to ksmartdata/redis-operator that referenced this pull request Dec 4, 2023
@jiuker @drivebyer
fix:resize cluster's pvc with wrong label (OT-CONTAINER-KIT#562)
ed62e30 
Signed-off-by: guozhi.li <[email protected]>
Co-authored-by: guozhi.li <[email protected]>
(cherry picked from commit 4395ff6)
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
@jiuker @mattrobinsonsre
fix:resize cluster's pvc with wrong label (OT-CONTAINER-KIT#562)
8abdf21 
Signed-off-by: guozhi.li <[email protected]>
Co-authored-by: guozhi.li <[email protected]>
Signed-off-by: Matt Robinson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham-cmyk shubham-cmyk shubham-cmyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiuker @shubham-cmyk