Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: when delete RedisCluster CR, finalizer doesn`t delete node-conf pvc because wrong pvcName #573

Closed
wants to merge 2 commits into from
Closed

bugfix: when delete RedisCluster CR, finalizer doesn`t delete node-conf pvc because wrong pvcName #573

wants to merge 2 commits into from

Conversation

Wangmin362
Copy link

Description

when delete RedisCluster CR, finalizer doesn`t delete node-conf pvc because wrong pvcName

Fixes #ISSUE

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Testing has been performed
  • No functionality is broken
  • Documentation updated

@shubham-cmyk
Copy link
Member

@Wangmin362
Please pass the DCO check

shubham-cmyk
shubham-cmyk approved these changes Sep 16, 2023
View reviewed changes
Copy link
Member

@shubham-cmyk shubham-cmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shubham-cmyk
Copy link
Member

@Wangmin362

Please resolve conflict and sign off your commit

@shubham-cmyk shubham-cmyk added this to the v0.15.1 milestone Sep 16, 2023
@shubham-cmyk
Copy link
Member

fixed in : #703

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham-cmyk shubham-cmyk shubham-cmyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.15.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Wangmin362 @shubham-cmyk