Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] : Refactor the backup and restore script and manifest #624

Merged
merged 5 commits into from
Sep 15, 2023

Conversation

shubham-cmyk
Copy link
Member

@shubham-cmyk shubham-cmyk commented Sep 15, 2023

Modifed scripts
added examples

@gitguardian
Copy link

gitguardian bot commented Sep 15, 2023

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- AWS Keys 6ba423e example/v1beta2/backup_restore/backup/env-secrets.yaml View secret
- AWS Keys 81c0981 example/v1beta2/backup_restore/backup/env-secrets.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@shubham-cmyk shubham-cmyk merged commit 3c7779a into OT-CONTAINER-KIT:master Sep 15, 2023
12 checks passed
@shubham-cmyk shubham-cmyk deleted the backup-fixes branch September 15, 2023 09:46
@shubham-cmyk shubham-cmyk changed the title [Fix] : Fix the backup and restore script and manifest [Refactor] : Refactor the backup and restore script and manifest Sep 18, 2023
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
…KIT#624)

* Add : job for bacup from the redis cluster

Signed-off-by: Shubham Gupta <[email protected]>

* remove unwanted var rom env_vars.env

Signed-off-by: Shubham Gupta <[email protected]>

* fix the backup scripts

Signed-off-by: Shubham Gupta <[email protected]>

* docker file

Signed-off-by: Shubham Gupta <[email protected]>

* write manifest for easy backup and restore

Signed-off-by: Shubham Gupta <[email protected]>

---------

Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: Matt Robinson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant