Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] : Added Custom EnvVars support #631

Merged
merged 5 commits into from
Sep 16, 2023

Conversation

sadath-12
Copy link
Contributor

@sadath-12 sadath-12 commented Sep 15, 2023

Fixes #630

Type of change

You can now add extra env field under to spec to configure additionalEnvs
For ex: under Spec section you can add ``` env:

  • name: CUSTOM_ENV_VAR_1
    value: "custom_value_1"
  • name: CUSTOM_ENV_VAR_2
    value: "custom_value_2" ```
  • New feature (non-breaking change which adds functionality)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

sadath-12 and others added 4 commits September 15, 2023 15:13
Signed-off-by: syedsadath-17 <[email protected]>
Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: Shubham Gupta <[email protected]>
@shubham-cmyk shubham-cmyk changed the title Feature: Added Custom EnvVars support [Feature] : Added Custom EnvVars support Sep 16, 2023
Signed-off-by: Shubham Gupta <[email protected]>
@shubham-cmyk shubham-cmyk merged commit e39e1d1 into OT-CONTAINER-KIT:master Sep 16, 2023
12 checks passed
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
* Feature: Added Custom EnvVars support

Signed-off-by: syedsadath-17 <[email protected]>

* Formatted Using fmt

Signed-off-by: syedsadath-17 <[email protected]>

* fixes on pr

Signed-off-by: Shubham Gupta <[email protected]>

* fixes on env

Signed-off-by: Shubham Gupta <[email protected]>

* push env Vars template

Signed-off-by: Shubham Gupta <[email protected]>

---------

Signed-off-by: syedsadath-17 <[email protected]>
Signed-off-by: Shubham Gupta <[email protected]>
Co-authored-by: Shubham Gupta <[email protected]>
Signed-off-by: Matt Robinson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose means and way to configure ENV vars to rediscluster, not just redis_exporter
2 participants