Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] - sts will never be created #663

Merged
merged 2 commits into from
Oct 7, 2023
Merged

[Fix] - sts will never be created #663

merged 2 commits into from
Oct 7, 2023

Conversation

drivebyer
Copy link
Collaborator

@drivebyer drivebyer commented Oct 7, 2023 •
edited
Loading

Description

Introduce by #653

err will be set to nil. Statefulset would not be created as well.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

@drivebyer drivebyer self-assigned this Oct 7, 2023
@drivebyer drivebyer changed the title Fix err would be set nil [Fix] - sts will never be created Oct 7, 2023
shubham-cmyk
shubham-cmyk approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@shubham-cmyk shubham-cmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shubham-cmyk shubham-cmyk merged commit 9ffe55a into OT-CONTAINER-KIT:master Oct 7, 2023
13 checks passed
@drivebyer drivebyer added the bug Something isn't working label Oct 17, 2023
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
@drivebyer @mattrobinsonsre
[Fix] - sts will never be created (OT-CONTAINER-KIT#663)
ac161b6 
* Fix err would be set nil

Signed-off-by: drivebyer <[email protected]>

* nolint for shadow

Signed-off-by: drivebyer <[email protected]>

---------

Signed-off-by: drivebyer <[email protected]>
Signed-off-by: Matt Robinson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham-cmyk shubham-cmyk shubham-cmyk approved these changes

Assignees

@drivebyer drivebyer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drivebyer @shubham-cmyk