Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : Add client for Testing #700

Merged
merged 7 commits into from
Nov 10, 2023
Merged

fix : Add client for Testing #700

merged 7 commits into from
Nov 10, 2023

Conversation

shubham-cmyk
Copy link
Member

@shubham-cmyk shubham-cmyk commented Nov 10, 2023 •
edited
Loading

part of : #656

@shubham-cmyk
mock client
8215c5e 
Signed-off-by: Shubham Gupta <[email protected]>
@shubham-cmyk
feat: add client
ae512de 
Signed-off-by: Shubham Gupta <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Nov 10, 2023 •
edited
Loading

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Files Coverage Δ
controllers/redissentinel_controller.go 0.00% <ø> (ø)
controllers/rediscluster_controller.go 0.00% <0.00%> (ø)
controllers/redisreplication_controller.go 0.00% <0.00%> (ø)
k8sutils/finalizer.go 16.66% <50.00%> (+13.54%) ⬆️

📢 Thoughts on this report? Let us know!

@shubham-cmyk
Add finalizers
7f9ae5d 
Signed-off-by: Shubham Gupta <[email protected]>
@shubham-cmyk
fix
618aa46 
Signed-off-by: Shubham Gupta <[email protected]>
@shubham-cmyk
Add Test
874c76c 
Signed-off-by: Shubham Gupta <[email protected]>
@shubham-cmyk
fix
8df718c 
Signed-off-by: Shubham Gupta <[email protected]>
@shubham-cmyk
fix
ab72efd 
Signed-off-by: Shubham Gupta <[email protected]>
@shubham-cmyk shubham-cmyk merged commit 36591d5 into OT-CONTAINER-KIT:master Nov 10, 2023
19 checks passed
@shubham-cmyk shubham-cmyk deleted the add-client branch November 10, 2023 19:58
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
@shubham-cmyk @mattrobinsonsre
fix : Add client for Testing (OT-CONTAINER-KIT#700)
f7d2c5e 
* mock client

Signed-off-by: Shubham Gupta <[email protected]>

* feat: add client

Signed-off-by: Shubham Gupta <[email protected]>

* Add finalizers

Signed-off-by: Shubham Gupta <[email protected]>

* fix

Signed-off-by: Shubham Gupta <[email protected]>

* Add Test

Signed-off-by: Shubham Gupta <[email protected]>

* fix

Signed-off-by: Shubham Gupta <[email protected]>

* fix

Signed-off-by: Shubham Gupta <[email protected]>

---------

Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: Matt Robinson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shubham-cmyk