Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] : cluster scaling #704

Merged
merged 6 commits into from
Nov 20, 2023
Merged

[Fix] : cluster scaling #704

merged 6 commits into from
Nov 20, 2023

Conversation

drivebyer
Copy link
Collaborator

  1. fix cluster scaling
  2. add e2e case

drivebyer and others added 4 commits November 18, 2023 22:33
@drivebyer
add scale e2e yamls
47a4e8f 
Signed-off-by: drivebyer <[email protected]>
@drivebyer
temp
12e5345 
Signed-off-by: drivebyer <[email protected]>
@drivebyer
fix the cluster scale
fcceea8 
Signed-off-by: drivebyer <[email protected]>
@drivebyer
adjust e2e
20ed4ee 
Signed-off-by: drivebyer <[email protected]>
@drivebyer drivebyer added the bug Something isn't working label Nov 20, 2023
@drivebyer drivebyer self-assigned this Nov 20, 2023
@drivebyer drivebyer enabled auto-merge (squash) November 20, 2023 13:36
@codecov Codecov
Copy link

codecov bot commented Nov 20, 2023 •
edited
Loading

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (6502c91) 27.90% compared to head (7da6ae3) 27.79%.

Files Patch % Lines
controllers/rediscluster_controller.go 0.00% 43 Missing ⚠️
k8sutils/cluster-scaling.go 0.00% 11 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #704      +/-   ##
==========================================
- Coverage   27.90%   27.79%   -0.11%     
==========================================
  Files          18       18              
  Lines        3111     3123      +12     
==========================================
  Hits          868      868              
- Misses       2216     2228      +12     
  Partials       27       27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer
increase timeout
5a53544 
Signed-off-by: drivebyer <[email protected]>
@drivebyer
add ready status
7da6ae3 
Signed-off-by: drivebyer <[email protected]>
shubham-cmyk
shubham-cmyk approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@shubham-cmyk shubham-cmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drivebyer drivebyer merged commit a597c39 into OT-CONTAINER-KIT:master Nov 20, 2023
19 of 21 checks passed
@drivebyer drivebyer deleted the clusterscale branch November 21, 2023 01:54
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
@drivebyer @mattrobinsonsre
[Fix] : cluster scaling (OT-CONTAINER-KIT#704)
e322f08 
* add scale e2e yamls

Signed-off-by: drivebyer <[email protected]>

* temp

Signed-off-by: drivebyer <[email protected]>

* fix the cluster scale

Signed-off-by: drivebyer <[email protected]>

* adjust e2e

Signed-off-by: drivebyer <[email protected]>

---------

Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: Matt Robinson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham-cmyk shubham-cmyk shubham-cmyk approved these changes

Assignees

@drivebyer drivebyer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drivebyer @shubham-cmyk