Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] : returned both a non-zero result and a non-nil error #705

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

drivebyer
Copy link
Collaborator

fix log with following message:

{"level":"info","ts":"2023-11-21T21:42:03+08:00","msg":"Warning: Reconciler returned both a non-zero result and a non-nil error. The result will always be ignored if the error is non-nil and the non-nil error causes reqeueuing with exponential backoff. For more details, see: https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/reconcile#Reconciler","controller":"rediscluster","controllerGroup":"redis.redis.opstreelabs.in","controllerKind":"RedisCluster","RedisCluster":{"name":"redis-cluster-v1beta2","namespace":"kuttl-test-social-bluejay"},"namespace":"kuttl-test-social-bluejay","name":"redis-cluster-v1beta2","reconcileID":"97a22714-ba92-41d6-a76a-0dbb67bf677d"}

The result will be ignore when error is non-nil.

https://github.com/kubernetes-sigs/controller-runtime/blob/5f8d96b043ef8ccadc544535415395be336630e8/pkg/reconcile/reconcile.go#L93-L95

Signed-off-by: drivebyer <[email protected]>
@drivebyer drivebyer added the enhancement New feature or request label Nov 21, 2023
@drivebyer drivebyer enabled auto-merge (squash) November 21, 2023 14:36
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (a597c39) 27.79% compared to head (afb4582) 27.79%.

Files Patch % Lines
controllers/rediscluster_controller.go 0.00% 14 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #705   +/-   ##
=======================================
  Coverage   27.79%   27.79%           
=======================================
  Files          18       18           
  Lines        3123     3123           
=======================================
  Hits          868      868           
  Misses       2228     2228           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer drivebyer merged commit 7692708 into OT-CONTAINER-KIT:master Nov 21, 2023
20 of 21 checks passed
@drivebyer drivebyer deleted the reconcile branch November 22, 2023 01:42
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants