feat: support exporter custom port #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #728 +/- ##
==========================================
+ Coverage 29.21% 29.43% +0.21%
==========================================
Files 18 19 +1
Lines 3135 3170 +35
==========================================
+ Hits 916 933 +17
- Misses 2191 2207 +16
- Partials 28 30 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: Shubham Gupta <[email protected]>
shubham-cmyk
approved these changes
Dec 17, 2023
api/v1beta2/rediscluster_default.go
Outdated
Comment on lines
10
to
14
| if r.Spec.RedisExporter != nil { | ||
| if r.Spec.RedisExporter.Port == nil { | ||
| r.Spec.RedisExporter.Port = pointer.Int(9121) | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| if r.Spec.RedisExporter != nil { | |
| if r.Spec.RedisExporter.Port == nil { | |
| r.Spec.RedisExporter.Port = pointer.Int(9121) | |
| } | |
| } | |
| if r.Spec.RedisExporter != nil && r.Spec.RedisExporter.Port == nil { | |
| r.Spec.RedisExporter.Port = pointer.Int(9121) | |
| } |
drivebyer
had a problem deploying
to
release-image
GitHub Actions
Failure
mattrobinsonsre
pushed a commit
to mattrobinsonsre/redis-operator
that referenced
this pull request
Jul 11, 2024
* support exporter custom port Signed-off-by: drivebyer <[email protected]> * add e2e Signed-off-by: drivebyer <[email protected]> --------- Signed-off-by: drivebyer <[email protected]> Signed-off-by: Matt Robinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When use hostnetwork, we need to specify exporter port to avoid port conflict too. Like redis custom port in #723
Type of change
Checklist
Additional Context