Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Redis AUTH password #734

Merged
merged 7 commits into from
Dec 18, 2023

Conversation

shubham-cmyk
Copy link
Member

@shubham-cmyk shubham-cmyk commented Dec 18, 2023

fix : #725

Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: Shubham Gupta <[email protected]>
@shubham-cmyk shubham-cmyk changed the title test: Fix Redis Password AUTH feat: Redis AUTH password Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (deefc14) 29.43% compared to head (ea05ef1) 29.37%.

Files Patch % Lines
k8sutils/redis-sentinel.go 0.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #734      +/-   ##
==========================================
- Coverage   29.43%   29.37%   -0.06%     
==========================================
  Files          19       19              
  Lines        3170     3176       +6     
==========================================
  Hits          933      933              
- Misses       2207     2212       +5     
- Partials       30       31       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: Shubham Gupta <[email protected]>
@shubham-cmyk shubham-cmyk merged commit 8e8ded9 into OT-CONTAINER-KIT:master Dec 18, 2023
25 of 27 checks passed
@shubham-cmyk shubham-cmyk deleted the fix-sentinel branch December 18, 2023 09:59
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
* make-codegen

Signed-off-by: Shubham Gupta <[email protected]>

* fix codegen

Signed-off-by: Shubham Gupta <[email protected]>

* fix test

Signed-off-by: Shubham Gupta <[email protected]>

* fix naming

Signed-off-by: Shubham Gupta <[email protected]>

* fix test file

Signed-off-by: Shubham Gupta <[email protected]>

* fix secret issues

Signed-off-by: Shubham Gupta <[email protected]>

* fix

Signed-off-by: Shubham Gupta <[email protected]>

---------

Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: Matt Robinson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When replication is configured with a password, Sentinel is unable to monitor replication correctly.
1 participant