Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exporter no auth to redis #743

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

drivebyer
Copy link
Collaborator

@drivebyer drivebyer commented Jan 10, 2024

Description

Fixes #724

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
@drivebyer drivebyer added the bug Something isn't working label Jan 10, 2024
Copy link

gitguardian bot commented Jan 10, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic Password 0a9f710 tests/e2e-chainsaw/v1beta2/password/redis-cluster/secret.yaml View secret
- Generic Password 0a9f710 tests/e2e-chainsaw/v1beta2/password/redis-standalone/secret.yaml View secret
- Generic Password 0a9f710 tests/e2e-chainsaw/v1beta2/password/redis-replication/secret.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Signed-off-by: drivebyer <[email protected]>
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (c8fd3bd) 28.75% compared to head (a6a4e2c) 28.74%.

❗ Current head a6a4e2c differs from pull request most recent head ed85bdf. Consider uploading reports for the commit ed85bdf to get more accurate results

Files Patch % Lines
k8sutils/statefulset.go 18.75% 12 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #743      +/-   ##
==========================================
- Coverage   28.75%   28.74%   -0.01%     
==========================================
  Files          19       19              
  Lines        3269     3287      +18     
==========================================
+ Hits          940      945       +5     
- Misses       2295     2307      +12     
- Partials       34       35       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer
Copy link
Collaborator Author

drivebyer commented Jan 10, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
🛠 Guidelines to remediate hardcoded secrets
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.Our GitHub checks need improvements? Share your feedbacks!

This pr change e2e password from Opstree@1234 to Opstree1234. Because the exporter mistinguish it with @ in address.

Signed-off-by: drivebyer <[email protected]>
@drivebyer drivebyer enabled auto-merge (squash) January 10, 2024 08:56
Copy link
Member

@shubham-cmyk shubham-cmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drivebyer drivebyer merged commit f07f596 into OT-CONTAINER-KIT:master Jan 10, 2024
26 checks passed
@drivebyer drivebyer deleted the exporter-auth branch January 10, 2024 09:13
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
* fix exporter no auth

Signed-off-by: drivebyer <[email protected]>

* add e2e

Signed-off-by: drivebyer <[email protected]>

* fix unit test

Signed-off-by: drivebyer <[email protected]>

* fix test

Signed-off-by: drivebyer <[email protected]>

---------

Signed-off-by: drivebyer <[email protected]>
Signed-off-by: Matt Robinson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When a password is configured for the Redis, retrieving Redis metrics encounters failure
2 participants