-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: exporter no auth to redis #743
Conversation
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
- | Generic Password | 0a9f710 | tests/e2e-chainsaw/v1beta2/password/redis-cluster/secret.yaml | View secret |
- | Generic Password | 0a9f710 | tests/e2e-chainsaw/v1beta2/password/redis-standalone/secret.yaml | View secret |
- | Generic Password | 0a9f710 | tests/e2e-chainsaw/v1beta2/password/redis-replication/secret.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Signed-off-by: drivebyer <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #743 +/- ##
==========================================
- Coverage 28.75% 28.74% -0.01%
==========================================
Files 19 19
Lines 3269 3287 +18
==========================================
+ Hits 940 945 +5
- Misses 2295 2307 +12
- Partials 34 35 +1 ☔ View full report in Codecov by Sentry. |
This pr change e2e password from |
Signed-off-by: drivebyer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix exporter no auth Signed-off-by: drivebyer <[email protected]> * add e2e Signed-off-by: drivebyer <[email protected]> * fix unit test Signed-off-by: drivebyer <[email protected]> * fix test Signed-off-by: drivebyer <[email protected]> --------- Signed-off-by: drivebyer <[email protected]> Signed-off-by: Matt Robinson <[email protected]>
Description
Fixes #724
Type of change
Checklist
Additional Context