Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redis replication integration tests #754

Conversation

MathieuCesbron
Copy link
Contributor

Description

Add redis replication integration tests. Redis sentinel will be the only one remaining after that.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

@MathieuCesbron MathieuCesbron force-pushed the Add_redis_replication_integration_tests branch from 5868fd8 to f52353f Compare January 19, 2024 15:51
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6bf05bc) 31.21% compared to head (f52353f) 32.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #754      +/-   ##
==========================================
+ Coverage   31.21%   32.11%   +0.89%     
==========================================
  Files          19       19              
  Lines        3232     3232              
==========================================
+ Hits         1009     1038      +29     
+ Misses       2174     2140      -34     
- Partials       49       54       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MathieuCesbron MathieuCesbron marked this pull request as ready for review January 19, 2024 15:57
@drivebyer drivebyer enabled auto-merge (squash) January 20, 2024 05:15
@drivebyer drivebyer merged commit f9938bc into OT-CONTAINER-KIT:master Jan 20, 2024
29 checks passed
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
* Remove commented code

Signed-off-by: Mathieu Cesbron <[email protected]>

* Add redis replication reconciler in suite test

Signed-off-by: Mathieu Cesbron <[email protected]>

* Add redis replication integration tests

Signed-off-by: Mathieu Cesbron <[email protected]>

---------

Signed-off-by: Mathieu Cesbron <[email protected]>
Signed-off-by: Matt Robinson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants