chore: remove latest version for conversion webhook #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathieu Cesbron <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #760 +/- ##
=======================================
Coverage 32.79% 32.79%
=======================================
Files 19 19
Lines 3232 3232
=======================================
Hits 1060 1060
Misses 2113 2113
Partials 59 59 ☔ View full report in Codecov by Sentry. |
|
Some people may still use v1beta1. IMO, we still need conversion in a period of time. |
|
Thanks for the comment. Yes, I agree we should only trigger the conversion for v1beta1 version and not for v1beta2 because it’s gonna convert nothing. That’s why I removed it from the selector. Am I missing something ? |
|
I'm not familiar with the |
drivebyer
changed the title
drivebyer
approved these changes
Jun 21, 2024
mattrobinsonsre
pushed a commit
to mattrobinsonsre/redis-operator
that referenced
this pull request
Jul 11, 2024
…#760) Remove latest version for conversion webhook Signed-off-by: Mathieu Cesbron <[email protected]> Signed-off-by: Matt Robinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The point of the conversion webhook is too update some v1beta1 fields basically and it does nothing for v1beta2. I removed the conversion webhook for v1beta2 version because there is no need to call the conversion for them.
Type of change
Checklist