<Icon>コンポーネントの実装をインラインSVGからmask-imageに移行
#61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciffelia
force-pushed
the
ciffelia/rewrite-icon-3
branch
from
948b438
to
bfade4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
<Icon>コンポーネントの実装を、SVGをHTML内に埋め込む方式から、mask-imageでSVG画像を表示する方式に変更した。Why
インラインSVGには次の問題があるため。
Note
mask-imageでSVG画像を表示する場合、HTMLの読み込みからアイコン表示までのタイムラグが増加するが許容する。<img>でSVG画像を読み込む方式はSVGの色を変えられないため採用できない。cf. https://zenn.dev/takepepe/articles/mask-image-icon
Close #43