Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #2476 by rearranging input validation requirements #2488

Closed
wants to merge 2 commits into from

Conversation

tghosth
Copy link
Collaborator

@tghosth tghosth commented Dec 26, 2024

This Pull Request relates to issue #2476

@tghosth tghosth linked an issue Dec 26, 2024 that may be closed by this pull request
@tghosth tghosth marked this pull request as draft December 26, 2024 15:18
@tghosth tghosth requested a review from elarlang December 26, 2024 15:18
@elarlang
Copy link
Collaborator

Attempt 416 to get it done :)

Tags - all MODIFIED, SPLIT FROM should be ADDED, SPLIT FROM.

11.3.1 and 11.3.2

  • I don't think "will be made" is correct form, "are made"?
  • For L2 - "should" vs "must"?

In general - for this kind of change it is better for trackability to make one move (commit) at a time.

@elarlang
Copy link
Collaborator

This one also?

V5.6.2 Verify that the application is designed to enforce input validation at a trusted service layer. While client-side validation improves usability, it must not be relied upon as a security control.

@tghosth
Copy link
Collaborator Author

tghosth commented Dec 31, 2024

@elarlang I updated the PR.

Once we have finalised the content, I may consider doing a different PR with the changes better organized as separate commits.

@tghosth
Copy link
Collaborator Author

tghosth commented Jan 1, 2025

Replaced by #2490

@tghosth tghosth closed this Jan 1, 2025
@tghosth tghosth deleted the 2476-should-input-validation-be-level-1 branch January 5, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should Input Validation be Level 1
2 participants