Fix: Add custom About dialog for non-macOS platforms (#421) #1175
Conversation
There was a problem hiding this comment.
hello @SidheshwarSarangal , thanks for this update, it is good to have
could you run the unit tests with npm test and make sure they pass?
td.vue/src/desktop/menu.js
Outdated
| parent: mainWindow, // Use mainWindow as the parent if applicable | ||
| resizable: false, | ||
| }); | ||
| aboutWin.loadFile('about.html'); // Load the 'about.html' file in the modal |
There was a problem hiding this comment.
does the about.html need to be created?
There was a problem hiding this comment.
I have checked. Currently, there is no about.html file in the repository. Should I create one for this task? If so, could you confirm the expected content or structure?
There was a problem hiding this comment.
I have added the about content. Please tell me if there is anything else.
|
I have added the about content. Please tell me if there is anything else. |
There was a problem hiding this comment.
I think there may be a better way to implement this, for example electron-about-window, or other ways of achieving this cross platform.
This is a commonly needed feature across most electron applications so there is probably going to be an easy path somewhere
|
Sir, I have used about-window for non mac os |
There was a problem hiding this comment.
hello @SidheshwarSarangal , could you look at your changes again? they do not seem to use package electron-about-window, see electron-about-window main.js for an example
Summary:
This pull request addresses Issue #421, which involves fixing the behavior of the "About" menu item in the application. Currently, the "About" dialog is not functioning as expected on non-macOS platforms. The fix ensures that the "About" dialog appears as a modal window for all platforms except macOS, where the native "About" dialog behavior is retained.
Description for the changelog:
Fixed the "About" menu behavior: non-macOS platforms now open a custom modal window, while macOS retains the native About dialog.
Other info:
This PR closes #421 and ensures the "About" menu item behaves appropriately across different platforms.
For macOS, the menu uses the default system behavior.
For non-macOS platforms, the "About" item opens a custom modal window displaying about.html.
This change ensures a more consistent and expected behavior for the "About" dialog across all platforms.