UNZER-498 Fix backend admin paymentId handling

OXID-eSales · Oct 9, 2024 · 68f7d04 · 68f7d04
1 parent c035417
commit 68f7d04
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 4 deletions.
diff --git a/src/Controller/Admin/AdminOrderController.php b/src/Controller/Admin/AdminOrderController.php
@@ -88,7 +88,7 @@ public function render()
 
             $transactionService = $this->getServiceFromContainer(TransactionService::class);
             $orderId = $this->getEditObjectId();
-            $paymentId = $transactionService->getPaymentIdByOrderId($orderId, true); //somthesing like s-chg-XXXX
+            $paymentId = $transactionService->getAdminPaymentIdByOrderId($orderId); //somthesing like s-chg-XXXX
             $this->sTypeId = $paymentId; /** may@throws \TypeError if $paymentId due to wrong payment cancellation */
             $this->_aViewData['sTypeId'] = $this->sTypeId;
             if ($this->sTypeId) {

diff --git a/src/Service/Transaction.php b/src/Service/Transaction.php
@@ -457,9 +457,7 @@ public function getPaymentIdByOrderId(string $orderid, bool $withoutCancel = fal
         $queryBuilder = $queryBuilderFactory->create();
 
         $query = $queryBuilder
-            ->select(
-                'typeid'
-            )
+            ->select('typeid')
             ->from('oscunzertransaction')
             ->distinct()
             ->where($queryBuilder->expr()->eq('oxorderid', ':oxorderid'))
@@ -480,6 +478,40 @@ public function getPaymentIdByOrderId(string $orderid, bool $withoutCancel = fal
         return $result;
     }
 
+    /**
+     * @param string $orderid
+     * @return string
+     * @throws Exception
+     * @throws \Doctrine\DBAL\Exception
+     * @SuppressWarnings(PHPMD.BooleanArgumentFlag)
+     */
+    public function getAdminPaymentIdByOrderId(string $orderid): string
+    {
+        $result = '';
+
+        $queryBuilderFactory = $this->getServiceFromContainer(QueryBuilderFactoryInterface::class);
+        $queryBuilder = $queryBuilderFactory->create();
+
+        $query = $queryBuilder
+            ->select('typeid')
+            ->from('oscunzertransaction')
+            ->distinct()
+            ->where($queryBuilder->expr()->eq('oxorderid', ':oxorderid'))
+            ->setMaxResults(1);
+
+        $parameters = [
+            ':oxorderid' => $orderid,
+        ];
+
+        $queryResult = $query->setParameters($parameters)->execute();
+        if ($queryResult instanceof ResultStatement && $queryResult->columnCount()) {
+            $result = $queryResult->fetchOne();
+            $result = is_string($result) ? $result : '';
+        }
+
+        return $result;
+    }
+
     /**
      * @param string $orderid
      * @return string