Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature admin -> dev 리뷰 응답 데이터 및 문의 권한 수정 #27

Merged
merged 10 commits into from
Sep 3, 2024

Conversation

Gomnonix
Copy link
Collaborator

@Gomnonix Gomnonix commented Sep 3, 2024

변경 사항 요약

�리뷰 응답 데이터 및 문의 권한 수정

변경 유형

  • 버그 수정 (기존 기능 수정)
  • 새로운 기능 (새로운 기능 추가)
  • 기타 (문서 수정, 스타일 수정 등)

체크리스트

  • 코드가 프로젝트의 스타일 가이드를 따릅니다.
  • 변경 사항이 문서에 반영되었습니다.
  • 새로운 경고를 생성하지 않습니다.
  • 관련된 이슈가 해결되었습니다.

@Gomnonix Gomnonix added the enhancement New feature or request label Sep 3, 2024
@Gomnonix Gomnonix requested a review from im-niber September 3, 2024 08:55
@Gomnonix Gomnonix self-assigned this Sep 3, 2024
Copy link
Collaborator

@im-niber im-niber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다~ 댓글 봐주십셔

Comment on lines 21 to 26
class QuestionListView(APIView):
def get_permissions(self):
if self.request.method == "GET":
return [AllowAny()]
return [IsAuthenticated()]

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 유저가 작성한 질문, 답변들도 볼 수 있을건데 상관 없나요? 기획 쪽에서 들은게 없어서ㅓㅓ 상관없다면 이대로 하시고 자기만 볼 수 있게 하는 기능이 필요하면 user_id 같은걸로 permission 줘야 할 거 같슴니다 !

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!!

@Gomnonix Gomnonix merged commit 8979f71 into dev Sep 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants