Skip to content

Commit

Permalink
upgrading electron to v9.4.4 and node to v14.16.1
Browse files Browse the repository at this point in the history
  • Loading branch information
rjoffray committed May 4, 2021
1 parent 39776c8 commit 4ef4534
Show file tree
Hide file tree
Showing 11 changed files with 388 additions and 254 deletions.
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v12.18.3
v14.16.1
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ git:
notifications:
email: false
node_js:
- "12.18.3"
- "14.16.1"
matrix:
include:
- os: linux
Expand Down
6 changes: 3 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:12.18.3-stretch
FROM node:14.16.1-stretch

ARG DEBIAN_FRONTEND=noninteractive

Expand Down Expand Up @@ -42,14 +42,14 @@ RUN npm install \

ENTRYPOINT ["oak"]

ENV npm_config_target=7.3.2 \
ENV npm_config_target=6.14.12 \
npm_config_runtime=electron \
npm_config_arch=x64 \
npm_config_target_arch=x64 \
npm_config_disturl=https://atom.io/download/electron \
DEBUG=false \
NODE_ENV=production \
ELECTRON_VERSION=7.3.2 \
ELECTRON_VERSION=9.4.4 \
DISPLAY=:0 \
IGNORE_GPU_BLACKLIST=false \
NODE_TLS_REJECT_UNAUTHORIZED=0 \
Expand Down
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Oak

[![release](https://img.shields.io/badge/release-v7.0.0-green.svg)](https://github.com/OakLabsInc/oak/releases/tag/7.0.0)
[![node](https://img.shields.io/badge/node-v12.18.3-green.svg)](https://github.com/nodejs/node/releases/tag/v12.18.3)
[![electron](https://img.shields.io/badge/electron-v7.3.2-green.svg)](https://github.com/electron/electron/releases/tag/v7.3.2)
[![release](https://img.shields.io/badge/release-v9.0.0-green.svg)](https://github.com/OakLabsInc/oak/releases/tag/9.0.0)
[![node](https://img.shields.io/badge/node-v14.16.1-green.svg)](https://github.com/nodejs/node/releases/tag/v14.16.1)
[![electron](https://img.shields.io/badge/electron-v9.4.4-green.svg)](https://github.com/electron/electron/releases/tag/v9.4.4)
[![Coverage Status](https://coveralls.io/repos/github/OakLabsInc/oak/badge.svg?t=zYcBU6)](https://coveralls.io/github/OakLabsInc/oak)
[![Standard - JavaScript Style Guide](https://img.shields.io/badge/code%20style-standard-green.svg)](http://standardjs.com/)

Expand All @@ -21,8 +21,8 @@ We recommend that you install Nodejs via Node Version Manager: [https://github.c
After you install and follow the instructions at the end (adding `nvm` to your path),

```sh
$ nvm install 12.18.3
$ nvm use 12.18.3
$ nvm install 14.16.1
$ nvm use 14.16.1
```

## Install
Expand Down
10 changes: 5 additions & 5 deletions docker-deploy.sh
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
#!/bin/bash -e

OAK_VERSION="7.0.0"
OAK_VERSION="9.0.0"
BASE="oaklabs/oak"

# our FROM line in the Dockerfile, should ideally match the current electron node version
ELECTRON_VERSION="7.3.2"
FROM="node:12.18.3-stretch"
ELECTRON_VERSION="9.4.4"
FROM="node:14.16.1-stretch"

NPM_URL="https://registry.npmjs.org/"

Expand All @@ -25,7 +25,7 @@ echo "** Building $BASE:$OAK_VERSION"
echo ""

docker build --compress -t $BASE:$OAK_VERSION .
# docker tag $BASE:$OAK_VERSION $BASE:latest
docker tag $BASE:$OAK_VERSION $BASE:latest

docker push $BASE:$OAK_VERSION
# docker push $BASE:latest
docker push $BASE:latest
2 changes: 1 addition & 1 deletion examples/inject-scripts/.nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v12.18.3
v14.16.1
2 changes: 1 addition & 1 deletion examples/multiple-windows/.nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v12.18.3
v14.16.1
2 changes: 1 addition & 1 deletion examples/simple-script/.nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v12.18.3
v14.16.1
2 changes: 1 addition & 1 deletion examples/simple-url/.nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v12.18.3
v14.16.1
Loading

0 comments on commit 4ef4534

Please sign in to comment.