Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update ajna contracts to rc10 / rc9.5 #529

Merged
merged 7 commits into from
Dec 4, 2023

Conversation

halaprix
Copy link
Member

Ticket URL

Please provide a link to the ticket:

Description of Changes

Please list the changes introduced by this PR:

  • updated ajna contracts to rc10
  • removed the usage of balanceOf to get withdrawn or repaid balance in favor of _roundUpToScale for repay and _roundToScale for withdraw
  • [ ]

How to Test

Please provide instructions on how to test the changes in this PR:

PR Definition of Done

Please ensure the following requirements have been met before marking the PR as ready for review:

  • All checks are passing
  • PR is linked to a corresponding ticket
  • PR title is clear and concise
  • Code has been self-reviewed and any fixes or improvements noted (See Code review standards in Notion)
  • Documentation has been updated if necessary

Copy link

This pull request has been linked to Shortcut Story #13156: [sc] - adjust tests and proxy actions to rc10(ish).

Copy link
Contributor

@robercano robercano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor concerns, approved anyway

@halaprix halaprix merged commit f5ef781 into dev Dec 4, 2023
2 checks passed
@halaprix halaprix deleted the kk/sc-13156/sc-adjust-tests-and-proxy-actions-to-rc10 branch December 4, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants